feature/update-tests-to-new-archetype #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-tests-to-new-archetype
CachedaCodes
suggested changes
Jul 15, 2022
| .children(`.x-column-picker-list__item--${columns}-cols`) | ||
| .should('be.visible') | ||
| .click(); | ||
| cy.get(`.x-column-picker-list__item--${columns}-cols`).click({ scrollBehavior: false }); |
There was a problem hiding this comment.
If we're not using the .getByDataTest('column-picker-list') here then change the test below to use the same formula as this one.
CachedaCodes
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Several tests were failing after new restyled archetype was released, mainly due to components being hidden from the main layout, new text literals and the sub-header dynamic behaviour that Cypress doesn't fancy. For more details please check the task description, where failed tests and failure description are listed.
Type of change
What is the destination branch of this PR?
MainChecklist: