-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: components loaded in chunks #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttps://github.com/empathyco/x-archetype into feature/EX-6472-new-archetype-layout-and-config-qa
…ttps://github.com/empathyco/x-archetype into feature/EX-6472-new-archetype-layout-and-config-qa
…into fix/EX-6531-fix-chunks-in-archetype
javieri-empathy
approved these changes
Jul 1, 2022
mnavarroespinosa
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking the stats.html you have to see 5 chunks: 1 for each message file (es and en), x-search, x-empty-search, and app.js
Also, you can use http-server to serve the files compressed and check if the chunks are properly loaded. To achieve that, you should compress the app.js, x-search.js, x-empty-search.js with brotli o gzip(gzip dist/app.js ....etc) and then serve them using http-server:
http-server -g
- gziphttp-server -b
- brotliChrome and Firefox don't accept brotli by default, if you wanna test it, you have to download this extension, extension and add the following rule:
accept-enconding: br
EX-6531