Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: styles issues #136

Merged
merged 21 commits into from
Jul 1, 2022
Merged

fix: styles issues #136

merged 21 commits into from
Jul 1, 2022

Conversation

diegopf
Copy link
Contributor

@diegopf diegopf commented Jun 30, 2022

mnavarroespinosa and others added 17 commits June 29, 2022 17:18
@mnavarroespinosa
feat: update style and config
ea74c05 
EX-6472
@diegopf
refactor: remove border radius for x-message
f9668bf
@diegopf
refactor: style recommendations title
90e83f9
@diegopf
refactor: autofocus input only if there's no query
28f1ca6
@diegopf
refactor: adjust total results message size
9722749
@diegopf
refactor: set default color for tags
122c423
@diegopf
refactor: adjust next queries group marings on mobile
12675b6
@mnavarroespinosa
fix: empty predictive layer when no suggestions
1fc0ff6
@mnavarroespinosa
feat: add i18n literals for sort
d75928a
@mnavarroespinosa
style: restore stroke width for icons
c08b938
@diegopf
Merge branch 'feature/EX-6472-new-archetype-layout-and-config-qa' of h…
0aec5eb 
…ttps://github.com/empathyco/x-archetype into feature/EX-6472-new-archetype-layout-and-config-qa
@diegopf
feat: add padding to search box input
a81c4a7
@diegopf
feat: align mobile floating
cab27bc
@diegopf
refactor: remove text decoration on mobile
ffcbde5
@mnavarroespinosa
style: change stroke width for light bulb on icon
65625be
@mnavarroespinosa
Merge branch 'feature/EX-6472-new-archetype-layout-and-config-qa' of h…
1246fbd 
…ttps://github.com/empathyco/x-archetype into feature/EX-6472-new-archetype-layout-and-config-qa
@diegopf
feat: prevent empty empathize
da1adb8
@diegopf diegopf requested a review from a team as a code owner June 30, 2022 13:57
@mnavarroespinosa mnavarroespinosa self-requested a review June 30, 2022 14:29
mavmaf
mavmaf suggested changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@mavmaf mavmaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following our conversation, please find below a summary of change requests:

  • Mobile. Add margin to the 'No results' message div
  • Desktop. Change query size on total-results to 16px
  • Desktop & Mobile. Try to align ID results text titles

@mnavarroespinosa
Copy link
Contributor

Following our conversation, please find below a summary of change requests:

  • Mobile. Add margin to the 'No results' message div
  • Desktop. Change query size on total-results to 16px
  • Desktop & Mobile. Try to align ID results text titles

Fixed the first 2 points, but we cannot align the ID results with the current implementation of the suggestions.

@mavmaf mavmaf self-requested a review July 1, 2022 08:45
mavmaf
mavmaf suggested changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@mavmaf mavmaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look to the no results page in mobile. If the query leading to no results is quite long, the text will be misaligned:
1656665963445

@mnavarroespinosa
Copy link
Contributor

Please take a look to the no results page in mobile. If the query leading to no results is quite long, the text will be misaligned: 1656665963445

Good catch! Fixed!

@mavmaf mavmaf self-requested a review July 1, 2022 11:27
mavmaf
mavmaf previously approved these changes Jul 1, 2022
View reviewed changes
tiborux
tiborux previously approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@tiborux tiborux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gj

@tiborux tiborux dismissed stale reviews from mavmaf and themself via 733b718 July 1, 2022 11:52
tiborux
tiborux approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@tiborux tiborux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gj

@tiborux tiborux merged commit 8514427 into main Jul 1, 2022
@tiborux tiborux deleted the feature/EX-6472-new-archetype-layout-and-config-qa branch July 1, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiborux tiborux tiborux approved these changes

@mavmaf mavmaf mavmaf approved these changes

@mnavarroespinosa mnavarroespinosa Awaiting requested review from mnavarroespinosa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diegopf @mnavarroespinosa @tiborux @mavmaf