Skip to content

Migrate e2e testing to integration_test#32

Merged
emostar merged 2 commits into
emostar:masterfrom
ened:integration_test
May 18, 2022
Merged

Migrate e2e testing to integration_test#32
emostar merged 2 commits into
emostar:masterfrom
ened:integration_test

Conversation

@ened

@ened ened commented Mar 26, 2021

Copy link
Copy Markdown
Collaborator

You can run the test in the example folder, using:

fvm flutter drive --driver=test_driver/integration_test.dart --target=integration_test/visitor_info_test.dart

We can not bump to Flutter2.x yet as the integration_test and pigeon packages are incompatible with each other. The PRs are on deck, for example here: flutter/packages#315

Looks like migration will be possible with Flutter 2.1+

@ened

ened commented Mar 26, 2021

Copy link
Copy Markdown
Collaborator Author

@emostar for your review

@ened ened force-pushed the integration_test branch from 30a2d7c to 33b1289 Compare March 26, 2021 18:47
@ryanheise

Copy link
Copy Markdown
Contributor

Would be nice to have this merged because the null safety migration (#35 ) can't happen without this.

Regarding pigeon, I've personally stayed away from it as I find it a bit too experimental, incomplete and rough around the edges. A quick and dirty approach to null safety (not worth merging but addressing any immediate needs) would be to migrate the generated pigeon code, so I may try to do that based on this fork.

@ryanheise ryanheise mentioned this pull request May 5, 2021
@ened

ened commented Sep 10, 2021

Copy link
Copy Markdown
Collaborator Author

@ryanheise things have moved on - pigeon may be a lot more stable now. @emostar do you still have interest in maintaining this plugin?

@ryanheise

Copy link
Copy Markdown
Contributor

My experience with using pigeon on a project was that it was nice, until I ran into a limitation and realised there was no way around it (on that occasion it was that pigeon didn't then support asynchronous methods.) It's slowly gaining more features but there's still just too much missing for now (e.g. flutter/flutter#66711 and flutter/flutter#66710). I'll probably give it another go in a year.

@emostar

emostar commented Sep 10, 2021

Copy link
Copy Markdown
Owner

@ryanheise things have moved on - pigeon may be a lot more stable now. @emostar do you still have interest in maintaining this plugin?

@ened Yes, I'm actually using this plugin in production apps. I may not always be very responsive here, as I have many obligations. If anyone is willing to help me out, I can add them to this repository and flutter pub so it's not dependent on me for every change and release.

@ened

ened commented Sep 10, 2021

Copy link
Copy Markdown
Collaborator Author

Yes why not. @emostar Let's do it.

@emostar

emostar commented Sep 10, 2021

Copy link
Copy Markdown
Owner

@ened I'll need your pub.dev email address to add you to the project.

@ened

ened commented Sep 11, 2021

Copy link
Copy Markdown
Collaborator Author

@ened I'll need your pub.dev email address to add you to the project.

<firstname>.<lastname>@gmail.com thx

@emostar emostar merged commit 33b1289 into emostar:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants