A faster htmlMatcher.js #457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed media=all from link:css since it's the de-facto standard, see http://perfectionkills.com/optimizing-html/#1_style_media_all
Свойство "word-wrap: break-word"
font-family: Arial
Now it can correctly parse attributes with single quotes
Emmet core now works in Dreamweaver
properties for outline-style
add property to "letter-spacing"
remove the extra properties word-break
add "font-family: "Times New Roman", Times, Baskerville, Georgia, serif;
!html modern expansion H5BP
* svg tags * SVG snippet fix * SVG snippets rework
* Introduce caniuse-db instead of old caniuse.json * Fix indent style
* Add meta:redirect snippet * Add variable to meta:redirect
CodersClan is no longer offering support services for Emmet
Minor refactoring
* Trim whitespace * Callback for `locateFile` function and throw error if file not exists * Add callback for create path & save
|
Great job! :) I’m going to do a full rewrite of Emmet soon and I’ll take into account your implementation. Lots of things will change in a new version |
eight04
force-pushed
the
dev-quick-match-2
branch
from
ae93300 to
75933fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrote htmlMatcher.js for better speed on Windows Script Host. But I don't know if it is faster in other environments, also the code is pretty messy. Anyway, here is how it does:
Take this file for example:
The original matcher will scan to top and bottom, match each tags, and return the result
[<html>, </html>]. Quick Match 2 will try scanning some tags around the cursor (i.e.</ul>, </li>, <a>, </html>) and "jump" to its pair (text.indexOf). So the matcher will not scan the entire content.Following steps show the main idea of quick-match-2 (forward search only, backward search is similar):
<a></a></html><html>, the cursor is inside the pair, return the result.Original discussion