Make it work on more platforms #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclips4
commented
Nov 17, 2025
| # depends on the headers through cpython-sys | ||
| rule="$objs: cpython-sys \$(srcdir)/Cargo.toml \$(srcdir)/Cargo.lock \$(srcdir)/$srcdir/$manifest $prefixed_srcs \$(PYTHON_HEADERS)" | ||
| rule="$rule; cargo build --lib --locked --package ${mods} --profile \$(CARGO_PROFILE)" | ||
| rule="$rule; CARGO_TARGET_DIR=\$(abs_builddir)/target PYTHON_BUILD_DIR=\$(abs_builddir) cargo build --lib --locked --package ${mods} --profile \$(CARGO_PROFILE) --manifest-path \$(srcdir)/Cargo.toml" |
Author
There was a problem hiding this comment.
We need this because some platforms build CPython outside the main source tree
Eclips4
commented
Nov 17, 2025
Comment on lines
+114
to
+120
| #[cfg(py_gil_disabled)] | ||
| pub const PyObject_HEAD_INIT: PyObject = { | ||
| let mut obj: PyObject = unsafe { std::mem::MaybeUninit::zeroed().assume_init() }; | ||
| obj.ob_flags = _Py_STATICALLY_ALLOCATED_FLAG as _; | ||
| obj | ||
| }; | ||
|
|
Author
There was a problem hiding this comment.
A temporary work around to make it build for free-threaded build
Eclips4
commented
Nov 17, 2025
Comment on lines
+89
to
+99
| def list_rust_modules(names: set[str]) -> None: | ||
| if not os.path.isdir(MODULES_PATH): | ||
| return | ||
| for entry in os.scandir(MODULES_PATH): | ||
| if not entry.is_dir(): | ||
| continue | ||
| if entry.name == "cpython-sys": | ||
| continue | ||
| cargo_toml = os.path.join(entry.path, "Cargo.toml") | ||
| if os.path.isfile(cargo_toml): | ||
| names.add(entry.name) |
Author
There was a problem hiding this comment.
We don’t actually need this in this PR, but we’ll eventually need something like it
Owner
There was a problem hiding this comment.
I think this should be fine! We can always modify it later as needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.