Make it build on mac #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclips4
commented
Nov 15, 2025
Comment on lines
+24
to
+30
| if normalized_path.startswith(SKIP_PREFIXES): | ||
| continue | ||
| if normalized_path in SKIP_EXACT: | ||
| continue | ||
| f.write(f"#include \"{normalized_path}\"\n") | ||
| if normalized_path == "Python/remote_debug.h": | ||
| f.write("#undef UNUSED\n") |
Author
There was a problem hiding this comment.
This is needed because Include/internal/pycore_crossinterp_data_registry.h is deliberately unguarded. It is supposed to be included only through Include/internal/pycore_crossinterp.h.
The regenerated wrapper was including the registry header twice, once indirectly via pycore_crossinterp.h (correct) and once directly (incorrect). Clang encounters the second inclusion of that unguarded header and fails
emmatyping
reviewed
Nov 15, 2025
| custom_ldflags="-Wl,--defsym=PyInit_$mod=PyInit_$mod" | ||
| case $UNAME_SYSTEM in | ||
| Darwin*) | ||
| custom_ldflags="$custom_ldflags -Wl,-u,_PyInit_$mod" |
Owner
There was a problem hiding this comment.
I should check to see if this works on Linux...
emmatyping
approved these changes
Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.