Add support for idle_timeout_ms#1425
Merged
kflynn merged 1 commit intoApr 11, 2019
Merged
Conversation
…nection use cases
Member
|
Looks good! Normally we'd need automated tests, too, but the test suite needs some work to handle timeouts right now, so I'm going to go ahead and land this one. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for Envoy's
idle_timeoutconfiguration with anidle_timeout_msmapping attribute. When set, this value overrides the Envoy connection manager widestream_idle_timeoutfor said route.idle_timeoutis used to bound the amount of time a request’s stream may be idle. This is especially important for long-lived connections (ex: gRPC) that currently get terminated after 300 seconds of inactivity due to the default value ofstream_idle_timeoutin envoy.Today, only values greater than 0 are supported (on the current envoy version) due to a bug in Envoy's config validation logic. In the future, setting this value to 0 should completely disable the route’s idle timeout, even if a connection manager stream idle timeout is configured. This has been fixed here: envoyproxy/envoy#6500 and should automatically work once released and the ambassador-envoy-alpine image is updated.
Example mapping for 1 hour idle timeout:
Testing
stream_idle_timeoutdefault).idle_timeout_msattribute on the gRPC service's Ambassador Mapping to 3600000 (1 hour)Todos