Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies for Java version #63

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Upgrade dependencies for Java version #63

merged 4 commits into from
Jan 23, 2025
+6 −5

Conversation

ndchorley
Copy link
Contributor

Just a heads up, also:

  • I upgraded the approval tests library, even though it isn't used (there are some unused imports though)
  • The project is compiling for Java 22, which isn't supported now. I suppose it's not too big a deal, but I could either change it to 23 (the current latest), or 21 (current LTS) as you prefer.

@codecop
Copy link
Contributor

codecop commented Dec 20, 2024

Can you change it to java 21 pls

@ndchorley
Copy link
Contributor Author

Done. Should I leave the dependency on Approval Tests and the unused imports?

@codecop
Copy link
Contributor

codecop commented Dec 22, 2024 •
edited
Loading

Yes please. There should be few differences to the branch with_tests if possible.
I guess you can send the same pr against the branch too

@codecop
Copy link
Contributor

codecop commented Jan 22, 2025

Thank you this looks good. @emilybache please merge

@emilybache emilybache merged commit f1e4a8c into emilybache:main Jan 23, 2025
@emilybache
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndchorley @codecop @emilybache