fix: make closeButton option in toast take precedence over Toaster #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jzxhuang
commented
Jan 23, 2024
Comment on lines
+80
to
+82
| const closeButton = React.useMemo( | ||
| () => toast.closeButton ?? closeButtonFromToaster, | ||
| [toast.closeButton, closeButtonFromToaster], |
| @@ -72,6 +72,7 @@ export interface HeightT { | |||
|
|
|||
| interface ToastOptions { | |||
| className?: string; | |||
| closeButton?: boolean; | |||
There was a problem hiding this comment.
not sure if this is actually needed, but I added it as a drive-by fix.
| @@ -173,7 +173,7 @@ toast.dismiss(); | |||
| | Property | Description | Default | | |||
| | :----------------- | :----------------------------------------------------------------------------------------------------: | -------------: | | |||
| | description | Toast's description, renders underneath the title. | `-` | | |||
| | closeButton | Adds a close button which shows on hover. | `false` | | |||
| | closeButton | Adds a close button. | `false` | | |||
There was a problem hiding this comment.
updating docs for changes in #227
SHABIN-K
referenced
this pull request
in SHABIN-K/Brainwave
Jan 30, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sonner](https://sonner.emilkowal.ski/) ([source](https://github.com/emilkowalski/sonner)) | [`1.3.1` -> `1.4.0`](https://renovatebot.com/diffs/npm/sonner/1.3.1/1.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>emilkowalski/sonner (sonner)</summary> ### [`v1.4.0`](https://github.com/emilkowalski/sonner/releases/tag/v1.4.0) [Compare Source](https://github.com/emilkowalski/sonner/compare/c449e2741368b04b4524859aa2a60696c0cfb58c...v1.4.0) #### What's Changed - Use bunchee as bundler by [@​huozhi](https://github.com/huozhi) in [https://github.com/emilkowalski/sonner/pull/276](https://github.com/emilkowalski/sonner/pull/276) - build: bump bundler for perf purpose by [@​huozhi](https://github.com/huozhi) in [https://github.com/emilkowalski/sonner/pull/277](https://github.com/emilkowalski/sonner/pull/277) - Fix light theme on homepage by [@​emilkowalski](https://github.com/emilkowalski) in [https://github.com/emilkowalski/sonner/pull/281](https://github.com/emilkowalski/sonner/pull/281) - feat: `description` support function in promise by [@​kahosan](https://github.com/kahosan) in [https://github.com/emilkowalski/sonner/pull/279](https://github.com/emilkowalski/sonner/pull/279) - add PR and issue templates by [@​choeqq](https://github.com/choeqq) in [https://github.com/emilkowalski/sonner/pull/286](https://github.com/emilkowalski/sonner/pull/286) - refactor: remove unused remaining time ref by [@​wobsoriano](https://github.com/wobsoriano) in [https://github.com/emilkowalski/sonner/pull/284](https://github.com/emilkowalski/sonner/pull/284) - types: change label types to ReactNode by [@​CanRau](https://github.com/CanRau) in [https://github.com/emilkowalski/sonner/pull/280](https://github.com/emilkowalski/sonner/pull/280) - feat: add `icons` prop to `<Toaster />` by [@​amirhhashemi](https://github.com/amirhhashemi) in [https://github.com/emilkowalski/sonner/pull/270](https://github.com/emilkowalski/sonner/pull/270) - Fix types of toaster icons by [@​emilkowalski](https://github.com/emilkowalski) in [https://github.com/emilkowalski/sonner/pull/294](https://github.com/emilkowalski/sonner/pull/294) - Fix loading icon bug by [@​emilkowalski](https://github.com/emilkowalski) in [https://github.com/emilkowalski/sonner/pull/295](https://github.com/emilkowalski/sonner/pull/295) - Add close button prop to toast by [@​emilkowalski](https://github.com/emilkowalski) in [https://github.com/emilkowalski/sonner/pull/296](https://github.com/emilkowalski/sonner/pull/296) - Swap bundlers by [@​emilkowalski](https://github.com/emilkowalski) in [https://github.com/emilkowalski/sonner/pull/297](https://github.com/emilkowalski/sonner/pull/297) - Dont dismiss loading toast by [@​emilkowalski](https://github.com/emilkowalski) in [https://github.com/emilkowalski/sonner/pull/298](https://github.com/emilkowalski/sonner/pull/298) - Upgrade bunchee for bundling bug fixes by [@​huozhi](https://github.com/huozhi) in [https://github.com/emilkowalski/sonner/pull/299](https://github.com/emilkowalski/sonner/pull/299) - bump packages by [@​choeqq](https://github.com/choeqq) in [https://github.com/emilkowalski/sonner/pull/283](https://github.com/emilkowalski/sonner/pull/283) - chore: remove unused npm lock file by [@​huozhi](https://github.com/huozhi) in [https://github.com/emilkowalski/sonner/pull/300](https://github.com/emilkowalski/sonner/pull/300) - fix: make closeButton option in toast take precedence over Toaster by [@​jzxhuang](https://github.com/jzxhuang) in [https://github.com/emilkowalski/sonner/pull/309](https://github.com/emilkowalski/sonner/pull/309) - Renaming too general className with project-specific one ([#​305](https://github.com/emilkowalski/sonner/issues/305)) by [@​jschoder](https://github.com/jschoder) in [https://github.com/emilkowalski/sonner/pull/315](https://github.com/emilkowalski/sonner/pull/315) - ghost-div doesn't block click in Firefox by [@​jschoder](https://github.com/jschoder) in [https://github.com/emilkowalski/sonner/pull/307](https://github.com/emilkowalski/sonner/pull/307) - Avoid issues with `<li>` offest when using different positions by [@​mmalomo](https://github.com/mmalomo) in [https://github.com/emilkowalski/sonner/pull/314](https://github.com/emilkowalski/sonner/pull/314) - Implement option to pause when document is hidden by [@​etcd](https://github.com/etcd) in [https://github.com/emilkowalski/sonner/pull/304](https://github.com/emilkowalski/sonner/pull/304) - Update bundler by [@​emilkowalski](https://github.com/emilkowalski) in [https://github.com/emilkowalski/sonner/pull/317](https://github.com/emilkowalski/sonner/pull/317) #### New Contributors - [@​kahosan](https://github.com/kahosan) made their first contribution in [https://github.com/emilkowalski/sonner/pull/279](https://github.com/emilkowalski/sonner/pull/279) - [@​choeqq](https://github.com/choeqq) made their first contribution in [https://github.com/emilkowalski/sonner/pull/286](https://github.com/emilkowalski/sonner/pull/286) - [@​CanRau](https://github.com/CanRau) made their first contribution in [https://github.com/emilkowalski/sonner/pull/280](https://github.com/emilkowalski/sonner/pull/280) - [@​amirhhashemi](https://github.com/amirhhashemi) made their first contribution in [https://github.com/emilkowalski/sonner/pull/270](https://github.com/emilkowalski/sonner/pull/270) - [@​jzxhuang](https://github.com/jzxhuang) made their first contribution in [https://github.com/emilkowalski/sonner/pull/309](https://github.com/emilkowalski/sonner/pull/309) - [@​jschoder](https://github.com/jschoder) made their first contribution in [https://github.com/emilkowalski/sonner/pull/315](https://github.com/emilkowalski/sonner/pull/315) - [@​mmalomo](https://github.com/mmalomo) made their first contribution in [https://github.com/emilkowalski/sonner/pull/314](https://github.com/emilkowalski/sonner/pull/314) - [@​etcd](https://github.com/etcd) made their first contribution in [https://github.com/emilkowalski/sonner/pull/304](https://github.com/emilkowalski/sonner/pull/304) **Full Changelog**: emilkowalski/sonner@v1.3.0...v1.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SHABIN-K/toss). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 😱:
closeButtonoption intoast(...)did not take precdence over theToasterglobal setting if passingfalse.You could test this like so:
the toast should NOT have the close button rendered. And can test the inverse too.