Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

egui_web: constrain the IME text agent to the canvas #830

Merged
merged 6 commits into from
Nov 2, 2021
Merged

egui_web: constrain the IME text agent to the canvas #830

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
60c40cd
Fix a display problem when entering text after the size of TextEdit e…
sumibi-yakitori Oct 21, 2021
a4b1b47
This fix was also applied to browsers other than Chrome
sumibi-yakitori Oct 21, 2021
b59d294
Revert "This fix was also applied to browsers other than Chrome"
sumibi-yakitori Nov 1, 2021
722fcdb
Revert "Fix a display problem when entering text after the size of Te…
sumibi-yakitori Nov 1, 2021
8546486
Fix to limit the position of the text agent to the height of the clie…
sumibi-yakitori Nov 1, 2021
cc79d05
Tweaking the code
sumibi-yakitori Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion egui_web/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1242,7 +1242,10 @@ fn move_text_cursor(cursor: &Option<egui::Pos2>, canvas_id: &str) -> Option<()>
if is_mobile() == Some(false) {
cursor.as_ref().and_then(|&egui::Pos2 { x, y }| {
let canvas = canvas_element(canvas_id)?;
let y = y + (canvas.scroll_top() + canvas.offset_top()) as f32;
let y = (y + (canvas.scroll_top() + canvas.offset_top()) as f32).min(
canvas.client_height() as f32
- text_agent().get_bounding_client_rect().height() as f32,
);
let x = x + (canvas.scroll_left() + canvas.offset_left()) as f32;
// Canvas is translated 50% horizontally in html.
let x = x - canvas.offset_width() as f32 / 2.0;
Expand Down