Use software texture filtering in kittest #7602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/7602-emilkpredictable-texture-filtering View snapshot changes at kitdiff |
aedm
requested changes
Oct 8, 2025
Contributor
|
Hello fellow kittest enjoyers... I think this predictable filtering might have caused some unpredictable issue 😅 #7630 |
Owner
Author
|
D'oh - good catch |
This was referenced Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My hope is that this will help in making kittest snapshot images come out the same on all hardware.
I ran
UPDATE_SNAPSHOTS=force cargo test --all-features --worskapceon main before, and there was no change (i.e. all images onmainare already pixel-perfect as they would be generated on my Mac).After the texture filtering change, all tests still passed, but using
UPDATE_SNAPSHOTS=forceagain I see a bunch of smaller changes in some of the images.