Skip to content

Optimize Mesh::add_rect_with_uv #7511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilk merged 1 commit into from
Sep 8, 2025
Merged

Optimize Mesh::add_rect_with_uv #7511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 27 additions & 27 deletions crates/epaint/src/mesh.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,7 @@ impl Mesh {
/// Add a triangle.
#[inline(always)]
pub fn add_triangle(&mut self, a: u32, b: u32, c: u32) {
self.indices.push(a);
self.indices.push(b);
self.indices.push(c);
self.indices.extend_from_slice(&[a, b, c]);
}

/// Make room for this many additional triangles (will reserve 3x as many indices).
Expand All @@ -189,33 +187,35 @@ impl Mesh {
}

/// Rectangle with a texture and color.
#[inline(always)]
pub fn add_rect_with_uv(&mut self, rect: Rect, uv: Rect, color: Color32) {
#![allow(clippy::identity_op)]

let idx = self.vertices.len() as u32;
self.add_triangle(idx + 0, idx + 1, idx + 2);
self.add_triangle(idx + 2, idx + 1, idx + 3);

self.vertices.push(Vertex {
pos: rect.left_top(),
uv: uv.left_top(),
color,
});
self.vertices.push(Vertex {
pos: rect.right_top(),
uv: uv.right_top(),
color,
});
self.vertices.push(Vertex {
pos: rect.left_bottom(),
uv: uv.left_bottom(),
color,
});
self.vertices.push(Vertex {
pos: rect.right_bottom(),
uv: uv.right_bottom(),
color,
});
self.indices
.extend_from_slice(&[idx + 0, idx + 1, idx + 2, idx + 2, idx + 1, idx + 3]);

self.vertices.extend_from_slice(&[
Vertex {
pos: rect.left_top(),
uv: uv.left_top(),
color,
},
Vertex {
pos: rect.right_top(),
uv: uv.right_top(),
color,
},
Vertex {
pos: rect.left_bottom(),
uv: uv.left_bottom(),
color,
},
Vertex {
pos: rect.right_bottom(),
uv: uv.right_bottom(),
color,
},
]);
}

/// Uniformly colored rectangle.
Expand Down
Loading