Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/7071-emilkfix-blurry-svg |
emilk
force-pushed
the
emilk/fix-blurry-svg
branch
from
7637d27 to
fb81f18
Compare
emilk
added a commit
to rerun-io/rerun
that referenced
this pull request
May 21, 2025
This should unblock using svg for icons, thanks to * emilk/egui#7071
darkwater
pushed a commit
to darkwater/egui
that referenced
this pull request
Aug 24, 2025
* Closes emilk#3501 The problem occurs when you want to render the same SVG at different scales, either at the same time in different parts of your UI, or at two different times (e.g. the DPI changes). The solution is to use the `SizeHint` as part of the key. However, when you have an SVG in a resizable container, that can lead to hundreds of versions of the same SVG. So new eviction code is added to handle this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem occurs when you want to render the same SVG at different scales, either at the same time in different parts of your UI, or at two different times (e.g. the DPI changes).
The solution is to use the
SizeHintas part of the key.However, when you have an SVG in a resizable container, that can lead to hundreds of versions of the same SVG. So new eviction code is added to handle this case.