Make close_popup take an Id and add close_all_popups #5820
Merged
lucasmerlin merged 3 commits intomasterfrom Mar 18, 2025
Merged
Make close_popup take an Id and add close_all_popups #5820lucasmerlin merged 3 commits intomasterfrom
close_popup take an Id and add close_all_popups #5820lucasmerlin merged 3 commits intomasterfrom
Conversation
lucasmerlin
commented
Mar 18, 2025
|
Preview available at https://egui-pr-preview.github.io/pr/5820-lucasfix-popup-with-context-menu |
lucasmerlin
changed the title
close_popup take an Id and add close_all_popups
emilk
approved these changes
Mar 18, 2025
darkwater
pushed a commit
to darkwater/egui
that referenced
this pull request
Aug 24, 2025
Ooops, fixes a regression introduced in emilk#5799 * [x] I have followed the instructions in the PR template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ooops, fixes a regression introduced in #5799