Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/5723-patch160 |
|
Can you explain why this change makes a difference? And what was changed for which reason? I tried to understand it from the diff but I can't make sense of it. |
In Windows, the |
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
The old code ignored the new EventResult from the call to run_ui_and_paint, so I think the new code makes sense. No idea why it is causing crashes though (and I'm not convinced it does, but I don't have a Windows machine 🤷)
crates/eframe/src/native/run.rs
Outdated
| } | ||
| EventResult::RepaintNow(window_id) => { | ||
| log::trace!("RepaintNow of {window_id:?}",); | ||
| self.windows_next_repaint_times.insert(window_id, now); |
There was a problem hiding this comment.
please revert the change to now - it is only adding confusion for no apparent gain
| self.windows_next_repaint_times.insert(window_id, now); | |
| self.windows_next_repaint_times.insert(window_id, Instant::now()); |
Dear emilk, Programs built with egui on Windows are terminating every hour on average. When this commit is applied, it works fine for about 3 to 6 hours on average. I've been testing it for over 6 months and have submitted multiple PRs since 6 months ago, but they haven't applied it yet. Thank you. --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
3 participants
Dear emilk,
Programs built with egui on Windows are terminating every hour on average.
When this commit is applied, it works fine for about 3 to 6 hours on average.
I've been testing it for over 6 months and have submitted multiple PRs since 6 months ago,
but they haven't applied it yet.
Thank you.