Fix modifiers not working in kittest #5693
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/5693-fix-kittest-modifiers |
emilk
approved these changes
Feb 7, 2025
Comment on lines
+400
to
+401
| let modifiers = modifiers | self.input.modifiers; | ||
| let previous_modifiers = mem::replace(&mut self.input.modifiers, modifiers); |
There was a problem hiding this comment.
nit: simpler/shorter
Suggested change
| let modifiers = modifiers | self.input.modifiers; | |
| let previous_modifiers = mem::replace(&mut self.input.modifiers, modifiers); | |
| let previous_modifiers = self.input.modifiers; | |
| self.input.modifiers |= modifiers; |
| last_mouse_pos: Pos2, | ||
| } | ||
|
|
||
| impl EventState { | ||
| pub fn kittest_event_to_egui(&mut self, event: kittest::Event) -> Option<egui::Event> { | ||
| /// Map the kittest events to egui events, add them to the input and update the modifiers. | ||
| /// This function accesses `egui::RawInput::modifiers`, make sure it is not reset after each |
There was a problem hiding this comment.
Suggested change
| /// This function accesses `egui::RawInput::modifiers`, make sure it is not reset after each | |
| /// This function accesses `egui::RawInput::modifiers`. Make sure it is not reset after each |
| } | ||
|
|
||
| /// Press a key with modifiers. | ||
| /// This will create a key down event and a key up event. | ||
| /// This will create a key down event, a key up event and update the modifiers. |
There was a problem hiding this comment.
Suggested change
| /// This will create a key down event, a key up event and update the modifiers. | |
| /// This will create a key-down event, a key-up event, and update the modifiers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It still isn't ideal, since you have to remember to call key_up on a separate frame.