POC: Bump rust-version to 1.78
#4954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To fix #4961 I also bumped web-sys to the newer version |
This was referenced Aug 14, 2024
Closed
bircni
changed the title
1.781.78 and fix web-sys error
|
Isn't there a point at keeping the MSRV as low as possible? That is, if needed, from dependencies or language features, bump it, but not just for the sake of it? (In my project, we had some reports after egui required 1.76 as it could not be built on some platforms.) Then it of course makes sense to test using the minimum version as well as the most recent (and possibly beta and nightly to catch upcoming problems). |
|
@oscargus yeah you are right first it was just like a poc |
bircni
changed the title
1.78 and fix web-sys error1.78
emilk
pushed a commit
that referenced
this pull request
Aug 26, 2024
486c
pushed a commit
to 486c/egui
that referenced
this pull request
Oct 9, 2024
This PR updates web-sys & wasm to the newest version. (this was already part of the POC emilk#4954 ) * Closes <emilk#4961> * Closes <emilk#4958> * [x] I have followed the instructions in the PR template
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
This PR updates web-sys & wasm to the newest version. (this was already part of the POC emilk#4954 ) * Closes <emilk#4961> * Closes <emilk#4958> * [x] I have followed the instructions in the PR template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the last update #4411 it's ok to be 2 versions behind and I think this would be useful.
To make this work I also updated the wasm version from 0.2.92 to 0.2.93
./scripts/check.sh