Fix missing winit feature in egui_glow
#4916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
approved these changes
Aug 5, 2024
emilk
changed the title
winit feature in egui_glow
486c
pushed a commit
to 486c/egui
that referenced
this pull request
Oct 9, 2024
Since emilk#4849, running `./scripts/check.sh` fails with: ``` ... error[E0277]: the trait bound `ActiveEventLoop: raw_window_handle::borrowed::HasDisplayHandle` is not satisfied --> crates/egui_glow/src/winit.rs:43:13 | 43 | event_loop, | ^^^^^^^^^^ the trait `raw_window_handle::borrowed::HasDisplayHandle` is not implemented for `ActiveEventLoop` | = help: the following other types implement trait `raw_window_handle::borrowed::HasDisplayHandle`: raw_window_handle::borrowed::DisplayHandle<'a> &H &mut H = note: required for the cast from `&ActiveEventLoop` to `&dyn raw_window_handle::borrowed::HasDisplayHandle` ``` This PR adds the missing `rwh_06` to the winit dependency (in egui-glow). * [x] I have followed the instructions in the PR template
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
Since emilk#4849, running `./scripts/check.sh` fails with: ``` ... error[E0277]: the trait bound `ActiveEventLoop: raw_window_handle::borrowed::HasDisplayHandle` is not satisfied --> crates/egui_glow/src/winit.rs:43:13 | 43 | event_loop, | ^^^^^^^^^^ the trait `raw_window_handle::borrowed::HasDisplayHandle` is not implemented for `ActiveEventLoop` | = help: the following other types implement trait `raw_window_handle::borrowed::HasDisplayHandle`: raw_window_handle::borrowed::DisplayHandle<'a> &H &mut H = note: required for the cast from `&ActiveEventLoop` to `&dyn raw_window_handle::borrowed::HasDisplayHandle` ``` This PR adds the missing `rwh_06` to the winit dependency (in egui-glow). * [x] I have followed the instructions in the PR template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #4849, running
./scripts/check.shfails with:This PR adds the missing
rwh_06to the winit dependency (in egui-glow).