Fix iOS build, and add iOS step to CI #4898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
lucasmerlin
force-pushed
the
add-ios-pipeline
branch
from
8b8f0e2
to
fdc0ab1
Compare
lucasmerlin
force-pushed
the
add-ios-pipeline
branch
from
fdc0ab1
to
6ebe97d
Compare
emilk
approved these changes
Aug 5, 2024
lucasmerlin
force-pushed
the
add-ios-pipeline
branch
from
6ebe97d
to
89a6fc5
Compare
|
@emilk finally got around to fixing the lint warnings, sorry it took so long |
486c
pushed a commit
to 486c/egui
that referenced
this pull request
Oct 9, 2024
<!-- Please read the "Making a PR" section of [`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md) before opening a Pull Request! * Keep your PR:s small and focused. * The PR title is what ends up in the changelog, so make it descriptive! * If applicable, add a screenshot or gif. * If it is a non-trivial addition, consider adding a demo for it to `egui_demo_lib`, or a new example. * Do NOT open PR:s from your `master` branch, as that makes it hard for maintainers to test and add commits to your PR. * Remember to run `cargo fmt` and `cargo clippy`. * Open the PR as a draft until you have self-reviewed it and run `./scripts/check.sh`. * When you have addressed a PR comment, mark it as resolved. Please be patient! I will review your PR, but my time is limited! --> This PR - adds a pipeline to check the ios build - removes the iOS WaitUntil workaround, which doesn't seem to be necessary anymore after the winit update (and caused the build for iOS to fail again because of a missing self - ~removes a iOS workaround for window size which doesn't seem necessary anymore~ Turns out it was still needed (but you need to actually restart the app for the issue to show up, so I didn't catch it first) - fixes some cargo check errors in run.rs I've done all these changes in a single PR because otherwise the pipeline doesn't run but I can also split them in separate PRs if that makes it easier to review
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
<!-- Please read the "Making a PR" section of [`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md) before opening a Pull Request! * Keep your PR:s small and focused. * The PR title is what ends up in the changelog, so make it descriptive! * If applicable, add a screenshot or gif. * If it is a non-trivial addition, consider adding a demo for it to `egui_demo_lib`, or a new example. * Do NOT open PR:s from your `master` branch, as that makes it hard for maintainers to test and add commits to your PR. * Remember to run `cargo fmt` and `cargo clippy`. * Open the PR as a draft until you have self-reviewed it and run `./scripts/check.sh`. * When you have addressed a PR comment, mark it as resolved. Please be patient! I will review your PR, but my time is limited! --> This PR - adds a pipeline to check the ios build - removes the iOS WaitUntil workaround, which doesn't seem to be necessary anymore after the winit update (and caused the build for iOS to fail again because of a missing self - ~removes a iOS workaround for window size which doesn't seem necessary anymore~ Turns out it was still needed (but you need to actually restart the app for the issue to show up, so I didn't catch it first) - fixes some cargo check errors in run.rs I've done all these changes in a single PR because otherwise the pipeline doesn't run but I can also split them in separate PRs if that makes it easier to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
removes a iOS workaround for window size which doesn't seem necessary anymoreTurns out it was still needed (but you need to actually restart the app for the issue to show up, so I didn't catch it first)
I've done all these changes in a single PR because otherwise the pipeline doesn't run but I can also split them in separate PRs if that makes it easier to review