Fix virtual keyboard on (mobile) web #4855
Conversation
| if runner.text_agent.has_focus() { | ||
| runner.text_agent.set_focus(false); | ||
| runner.text_agent.set_focus(true); | ||
| } |
There was a problem hiding this comment.
What the intention to do that? If this is some workaround it should be documented explicitly, because it could introduce unintended behaviour in other places and if such behaviour would be found and traced down to this lines is should be obvious why they are here.
|
Hello, I have carried out several tests of my own and they all seem to work. Thanks again for your library |
|
@emilk do you think you could give this another review? I'm trying to hackily copy text_agent behavior into bevy in vladbat00/bevy_egui#279 and this change would help. |
emilk
added
web
|
|
Hello, |
|
You should be able to fix this branch with |
|
I think I succeeded, I'm sorry for the amount of commits and the repetition of texts... :/ |
emilk
changed the title
|
I tested it again now, and on iOS Safari it now works great. Awesome work! |
Hello, I have made several corrections to stabilize the virtual keyboard on Android and IOS (Chrome and Safari). I don't know if these corrections can have a negative impact in certain situations, but at the moment they don't cause me any problems. I'll be happy to answer any questions you may have about these fixes. These fixes correct several issues with the display of the virtual keyboard, particularly since update 0.28, which can be reproduced on the egui demo site. We hope to be able to help you. Thanks a lot for your work, I'm having a lot of fun with egui :)
Hello, I have made several corrections to stabilize the virtual keyboard on Android and IOS (Chrome and Safari). I don't know if these corrections can have a negative impact in certain situations, but at the moment they don't cause me any problems. I'll be happy to answer any questions you may have about these fixes. These fixes correct several issues with the display of the virtual keyboard, particularly since update 0.28, which can be reproduced on the egui demo site. We hope to be able to help you. Thanks a lot for your work, I'm having a lot of fun with egui :)
Hello,
I have made several corrections to stabilize the virtual keyboard on Android and IOS (Chrome and Safari).
I don't know if these corrections can have a negative impact in certain situations, but at the moment they don't cause me any problems.
I'll be happy to answer any questions you may have about these fixes.
These fixes correct several issues with the display of the virtual keyboard, particularly since update 0.28, which can be reproduced on the egui demo site.
We hope to be able to help you.
Thanks a lot for your work, I'm having a lot of fun with egui :)