Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iOS compilation of eframe #4851

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fix iOS compilation of eframe #4851

merged 1 commit into from
Jul 31, 2024

Conversation

ardocrat
Copy link
Contributor

Fixed changed the name of function WinitApp::get_window_winit_id to WinitApp::window_id_from_viewport_id and missed egui::ViewportId import.

@lucasmerlin
Copy link
Collaborator

I can confirm that this fixes the iOS build. @emilk can you merge this? Maybe we should add a pipeline to test if egui's iOS build still works? I could give that a try

emilk
emilk approved these changes Jul 31, 2024
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It would be greatly appreciated if someone added an iOS build to CI to catch this in the future

@emilk emilk added bug Something is broken eframe Relates to epi and eframe iOS labels Jul 31, 2024
@emilk emilk changed the title Fix eframe winit redraw for iOS Fix iOS compilation of eframe Jul 31, 2024
@emilk emilk merged commit dfbc7f0 into emilk:master Jul 31, 2024
21 of 22 checks passed
@ardocrat ardocrat deleted the eframe_ios_fix branch July 31, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
bug Something is broken eframe Relates to epi and eframe iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ardocrat @lucasmerlin @emilk