Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ScrollArea #4770

Closed
wants to merge 6 commits into from
Closed

Fix: ScrollArea #4770

wants to merge 6 commits into from

Conversation

rustbasic
Copy link
Contributor

This is needed to resolve the following explanation, which cannot be resolved by #4754.

            // Move the scrollbar so it is visible. This is needed in some cases.
            // For instance:
            // * When we have a vertical-only scroll area in a top level panel,
            //   and that panel is not wide enough for the contents.
            // * When one ScrollArea is nested inside another, and the outer
            //   is scrolled so that the scroll-bars of the inner ScrollArea (us)
            //   is outside the clip rectangle.
            // Really this should use the tighter clip_rect that ignores clip_rect_margin, but we don't store that.
            // clip_rect_margin is quite a hack. It would be nice to get rid of it.

@emilk
Copy link
Owner

emilk commented Jul 5, 2024

I feel we need to add some proper tests for ScrollArea, or we will just regress old bugs.

Also: please explain what a PR is supposed to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants