Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The contents of #4284 have been reverted #4290

Closed
wants to merge 24 commits into from

Conversation

rustbasic
Copy link
Contributor

@rustbasic rustbasic commented Mar 31, 2024

@emilk
Copy link
Owner

emilk commented Mar 31, 2024

Which commit in https://github.com/emilk/egui/pull/4284/commits caused a problem for you?

@rustbasic
Copy link
Contributor Author

rustbasic commented Mar 31, 2024

Which commit in https://github.com/emilk/egui/pull/4284/commits caused a problem for you?

Yes, #4284

I haven't looked into it in detail yet, other than that it caused a problem and that reverting it solves it.

@rustbasic
Copy link
Contributor Author

rustbasic commented Apr 1, 2024

@emilk

If we don't return, we can confirm that there is no problem.

may be, Even if we don't 'return`, the result of fast speed we want is still there.

@emilk emilk closed this in #4296 Apr 1, 2024
@emilk emilk closed this in e99bd00 Apr 1, 2024
@rustbasic rustbasic deleted the patch34 branch April 1, 2024 10:45
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
…since it is reportedly broken on Windows

* Early-out added in emilk#4284
* Re-opens emilk#4173 😭 
* Closes emilk#4289
* Closes emilk#4290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After the #4284 update, Viewport graphics are broken.
2 participants