Add accessibility to ProgressBar and Spinner
#4139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
emilk
changed the title
ProgressBar and Spinner accessibleProgressBar and Spinner
emilk
changed the title
ProgressBar and SpinnerProgressBar and Spinner
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
- Introduces `WidgetType::ProgressIndicator` and maps it to the corresponding AccessKit role. - A `Spinner` is now exposed as a widget indicating a progress for which a completion state is not known. - On the other hand, a `ProgressBar` reports a completion state and can possibly be labeled. Note that a label is not used if not explicitly asked by the user, as it would be redundant information. Assistive technologies prefer the numerical value so they can, for instance, emit beeps of which the frequency rise as the completion state increase. I had to call `floor` on the progression as it seems all the ATs I tested would round the value, hence reporting something different than what is displayed on the label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WidgetType::ProgressIndicatorand maps it to the corresponding AccessKit role.Spinneris now exposed as a widget indicating a progress for which a completion state is not known.ProgressBarreports a completion state and can possibly be labeled. Note that a label is not used if not explicitly asked by the user, as it would be redundant information. Assistive technologies prefer the numerical value so they can, for instance, emit beeps of which the frequency rise as the completion state increase. I had to callflooron the progression as it seems all the ATs I tested would round the value, hence reporting something different than what is displayed on the label.