egui: Fixed the incorrect display of the Window frame with a wide border or large rounding

[varphone]

Currently, the Window frame is displayed incorrectly when using a wide border or large rounding.

• Closes Window title bar border disappears  #3806

• Closes Width of the window title bar with custom frame #4024

• Closes Width of the window title bar with custom frame #4024 #4025

• Screencast of egui demo app (emilk:master)

window-frame-bug.webm

• Screencast of egui demo app (varphone:hotfix/window-custom-frame)

window-frame-fixed.webm

[rustbasic]

@varphone

Thank you for your hard work on this time-consuming task. It is greatly appreciated.

Pressing collapse, depending on whether the window has focus or not,
the border at the bottom or right end of the title is infringed by about 0.5 to 1.0 (border.width 1.0 ~ 2.0).

Adding two lines below line 397 of window.rs improves it somewhat, but it's not perfect.

        let window_margin = window_frame.inner_margin;
        let border_stroke = ctx.style().visuals.widgets.noninteractive.bg_stroke;
        window_frame.inner_margin = window_frame.inner_margin + Margin::same(border_stroke.width);

[varphone]

@varphone

Thank you for your hard work on this time-consuming task. It is greatly appreciated.

Pressing collapse, depending on whether the window has focus or not, the border at the bottom or right end of the title is infringed by about 0.5 to 1.0 (border.width 1.0 ~ 2.0).

Adding two lines below line 397 of window.rs improves it somewhat, but it's not perfect.

        let window_margin = window_frame.inner_margin;
        let border_stroke = ctx.style().visuals.widgets.noninteractive.bg_stroke;
        window_frame.inner_margin = window_frame.inner_margin + Margin::same(border_stroke.width);

@rustbasic

Issue resolved in commit 4d2edb5

[rustbasic]

@varphone

This is good.
thank you

The border at the right end of the title is violated by about 0.1 to 0.5.
You can tell by looking closely at the color window.
I don't think it's a big worry.

I think we both had a good collaboration. Of course your power was greater.
have a good day.

[rustbasic]

@varphone

Dear varphone

I recently planned to find a solution to symptom #3730.

#3730 Do you have any symptoms?

If symptoms occur, do you solve them together ?

[varphone]

@varphone

This is good. thank you

The border at the right end of the title is violated by about 0.1 to 0.5. You can tell by looking closely at the color window. I don't think it's a big worry.

I think we both had a good collaboration. Of course your power was greater. have a good day.

Currently shrink by 0.1 to prevent the title bar hline from infringing the border,
To completely solve the problem should be calculated using TessellationOptions::feathering_size_in_pixels,
But now it works perfectly for most use cases.

79a8cc7

[varphone]

@varphone

Dear varphone

I recently planned to find a solution to symptom #3730.

#3730 Do you have any symptoms?

If symptoms occur, do you solve them together ?

Dear rustbasic

This scenario hasn't been encountered yet. Further testing will be conducted when time permits.

[rustbasic]

Currently shrink by 0.1 to prevent the title bar hline from infringing the border, To completely solve the problem should be calculated using TessellationOptions::feathering_size_in_pixels, But now it works perfectly for most use cases.

79a8cc7

@varphone
I mean the right end of the title, not the hline() line below the title.
You did a really good job today.
Take a good rest.