Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the default features of wgpu #3875

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Conversation

emilk
Copy link
Owner

@emilk emilk commented Jan 23, 2024

This makes all wgpu features opt-in for egui-wgpu users.

For eframe, I opted to enable some wgpu features so users can still use eframe without having to also opt-in to extra ewgpu features (eframe is batteries-included).

@emilk emilk mentioned this pull request Jan 23, 2024
@emilk emilk added the dependencies Pull requests that update a dependency file label Jan 23, 2024
@emilk emilk requested a review from Wumpf January 23, 2024 13:48
@emilk emilk force-pushed the emilk/wgpu-no-default-features branch from 9726e4c to 6602fdc Compare January 23, 2024 14:19
@emilk emilk added the eframe Relates to epi and eframe label Jan 23, 2024
Copy link
Contributor

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Collaborator

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@emilk emilk merged commit 3a8e234 into master Jan 24, 2024
35 checks passed
@emilk emilk deleted the emilk/wgpu-no-default-features branch January 24, 2024 08:43
@emilk emilk changed the title egui-wgpu: turn off the default features of wgpu Disable unused, default features of wgpu Feb 5, 2024
@emilk emilk changed the title Disable unused, default features of wgpu Disable the default features of wgpu Feb 5, 2024
emilk pushed a commit that referenced this pull request Mar 4, 2024
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file eframe Relates to epi and eframe egui-wgpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants