Fix IME input of CompositionEnd without a CompositionStart
#3768
Conversation
…y input character.
emilk
changed the title
CompositionEnd without a CompositionStart
Co-authored-by: Emil Ernerfeldt <[email protected]>
| @@ -1050,7 +1050,8 @@ fn events( | |||
| } | |||
|
|
|||
| Event::CompositionEnd(prediction) => { | |||
| if prediction != "\n" && prediction != "\r" && state.has_ime { | |||
| // CompositionEnd only characters may be typed into TextEdit without trigger CompositionStart first, so do not check `state.has_ime = true` in the following statement. | |||
There was a problem hiding this comment.
Is it still correct to check it for Event::CompositionUpdate above?
There was a problem hiding this comment.
This page show that compositionstart could be fired after a user starts entering a Chinese character using a Pinyin, so when entering some word except compositionend character, componentstart fires and state.has_ime will always be true, and compositionupdate will work well. so it's still correct to check it for compositionupdate because state.has_ime is always true when entring word.
I have test the situation that remove all state.has_ime in CompositionStart, CompositionUpdate,CompositionEnd, it works well.
Also, state.has_ime is a variable that indicating current input state, maybe some other features will use this variable, so i think keep this variable is a good choice, although it seems useless at current time.
emilk
changed the title
CompositionEnd without a CompositionStartCompositionEnd without a CompositionStart
Add support for type in CompositionEnd only characters without trigger CompositionStart first.
This usually works with no-latin character input.