egui-wgpu: reduce input latency by defaulting to double-buffering #3714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a huge difference in perceived latency on my 60 Hz monitor on macOS on a native build. There is no difference on web though afaict. For me this is a much better default. Tearing is mildly annoying, but input latency makes an aplication feel sluggish.
emilk
added
eframe
4 tasks
|
Sadly this will burn a lot of cpu, since we will repaint as fast as we can (e.g. at 500Hz), ignoring the monitor refresh rate. |
6 tasks
|
With the PR mentioned above now merged, is this unblocked? |
|
Yes! I'll make a new PR though since this the API for this changed |
emilk
added a commit
that referenced
this pull request
Jan 24, 2024
Setting `desired_maximum_frame_latency` to a low value should theoretically lead to lower latency in winit apps using `egui-wgpu` (e.g. in `eframe` with `wgpu` backend). * Replaces #3714 * See also gfx-rs/wgpu#4899 ---- It seems like `desired_maximum_frame_latency` has no effect on my Mac. I lowered my monitor refresh-rate to 30Hz to test, and can see no difference between `desired_maximum_frame_latency` of `0` or `3`. Before when experimenting with changing the global `DESIRED_NUM_FRAMES` in `wgpu` I saw a huge difference, so I wonder what has changed. I verified that `set_maximum_drawable_count` is being called with either `1` or `2`, but I perceive no difference between the two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a huge difference in perceived latency on my 60 Hz monitor on macOS on a native build.
There is no difference on web though afaict.
For me this is a much better default. Tearing is mildly annoying in some circumstances, but input latency makes an application feel sluggish all the time.