Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow arrow keys to move away focus from a Slider #3641

Merged
merged 2 commits into from
Jan 6, 2024
Merged

Allow arrow keys to move away focus from a Slider #3641

merged 2 commits into from
Jan 6, 2024

Conversation

fornwall
Copy link
Contributor

No description provided.

@fornwall
Copy link
Contributor Author

Is it better to keep an arrow field on EventFilter here and change it into a enum ArrowDirection { Horizontal, Vertical, Both } instead of having two boolean fields?

@fornwall fornwall mentioned this pull request Nov 27, 2023
Open
26 tasks
emilk
emilk approved these changes Jan 6, 2024
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@emilk emilk added the egui label Jan 6, 2024
@emilk emilk merged commit 37762f7 into emilk:master Jan 6, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
egui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fornwall @emilk