Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly reverse bool animation if value changes before it's finished #3577

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Properly reverse bool animation if value changes before it's finished #3577

merged 3 commits into from
Nov 21, 2023

Conversation

YgorSouza
Copy link
Contributor

Closes #3576.

@YgorSouza
Copy link
Contributor Author

Before:

animate-bool-bug.mp4

After:

animate-bool-fixed.mp4

@emilk emilk added the egui label Nov 21, 2023
emilk
emilk approved these changes Nov 21, 2023
View reviewed changes
Copy link
Owner

@emilk emilk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@emilk emilk merged commit 78a93f8 into emilk:master Nov 21, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
egui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

animated_bool jumps if the bool changes before it finishes
2 participants
@YgorSouza @emilk