-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rounding of ImageButton
#3531
Conversation
One thing I noticed with the current approach in this PR is that when using e.g., I thought this existing logic would allow it all to fit: egui/crates/egui/src/widgets/button.rs Line 647 in f218825
Also, any insight into why |
I'm fine with this although I'd also like to see the |
I haven't tried it but it looks okay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, thanks!
You're welcome! Happy to contribute. |
Updated
ImageButton
to use rounding from the corresponding image viaself.image.image_options().rounding
and added arounding()
method toImageButton
.Closes #3486
if we agree the addition of arounding()
method on theImageButton
itself, which the issue also mentions, can be discussed and handled separately.This now fully closes #3486