Log warning instead of error when failing to decode RON in storage #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
approved these changes
Apr 27, 2023
emilk
added a commit
to rerun-io/rerun
that referenced
this pull request
Apr 27, 2023
Because it can apparaently cause crashes: emilk/egui#2961
1 task
emilk
added a commit
to rerun-io/rerun
that referenced
this pull request
Apr 27, 2023
Because it can apparaently cause crashes: emilk/egui#2961
jleibs
pushed a commit
to rerun-io/rerun
that referenced
this pull request
May 2, 2023
Because it can apparaently cause crashes: emilk/egui#2961
jleibs
pushed a commit
to rerun-io/rerun
that referenced
this pull request
May 2, 2023
Because it can apparaently cause crashes: emilk/egui#2961
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why, but using
console.errorcauses a hard crash.But this PR fixes it. I don't understand why.