-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for requesting the user's attention to the window #2905
Conversation
#2900 has been merged - please rebase on it 🙏 |
e5c3e60
to
f1c9833
Compare
…tion`s (also, document the enum members now that they don't mirror `winit`)
f1c9833
to
f6447e6
Compare
all done, thanks for the quick response |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - it would be nice with a test of this in egui_demo_app
:s backend_panel.rs
- e.g. a button to request attention after a two-second delay (so the user can alt-tab away and test it properly)
Co-authored-by: Emil Ernerfeldt <[email protected]>
can do that in the present PR, or file a new one -- what do you prefer? I have a tester app already so it won't be too much work either way |
A separate app to test this would make sense! Please add it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good example, and works like a charm, but please get rid of the chrono
dependency 🙏
Co-authored-by: Emil Ernerfeldt <[email protected]>
Thank you! |
master
if eframe: Read and request window focus #2900 is mergedexamples
calls
request_user_attention()
with different platform-dependent effects, as seen inUserAttentionType
's documentation. the attention type enum (almost) mirrors that of winit's but I'm open to other options if this is not how it should be done.example action (windows)
source: https://github.com/TicClick/egui-attention-tester
2023-04-16.05-04-18.mp4