Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egui-winit: Remove android-activity dependency + add Activity backend features #2863

Merged
merged 1 commit into from
Apr 18, 2023

Commits on Apr 1, 2023

  1. Remove android-activity dependency + add activity features

    Instead of depending on android-activity directly, this exposes the
    android-native-activity and android-game-activity features from Winit.
    
    This ensures that applications can choose what android-backend they use
    while also relying on Winit to decide what version of android-activity to
    use - without increasing the risk of a version conflict by having a direct
    dependency.
    
    _(NB: Egui doesn't currently use the android-activity API itself)_
    
    Since android-activity provides the `android_main()` entry point for
    Android applications it's not possible to link in multiple version of
    the android-activity crate and so it's particularly important to
    avoid unnecessary direct dependencies that could cause a version
    conflict in the future.
    
    To help avoid the need for applications to directly depend on
    android-activity the Winit crate re-exports the android-activity API
    and exposes features to configure the backend so that application crates
    can instead rely on Winit to pull in a compatible version of
    android-activity. (This way version bumps for android-activity only
    need to be synchronized with the Winit crate).
    
    CI now enables the `android-native-activity` feature for testing.
    
    Fixes: emilk#2829
    Fixes: emilk#2720
    Closes: emilk#2834
    rib committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    619fee0 View commit details
    Browse the repository at this point in the history