Remove problematic clip code from ScrollArea
#2839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barugon
changed the title
ScrollAreaScrollArea
emilk
reviewed
Mar 29, 2023
Comment on lines
-451
to
-456
| if state.show_scroll[d] { | ||
| // Make sure content doesn't cover scroll bars | ||
| let tiny_gap = 1.0; | ||
| content_clip_rect.max[1 - d] = | ||
| inner_rect.max[1 - d] + scroll_bar_inner_margin - tiny_gap; | ||
| } |
There was a problem hiding this comment.
The 1-d is not incorrect. When we have a horizontal scroll-bar (d = 0), the scrollbar itself is at he bottom of the vertical dimension (1-d), and the other way around.
I believe this code was added to handle nested scroll-areas. Have you tried that?
There was a problem hiding this comment.
I have not. I'll tinker with it and see what I can find.
There was a problem hiding this comment.
I believe this code was added to handle nested scroll-areas. Have you tried that?
Do you have some code to specifically test this?
There was a problem hiding this comment.
What I mean is something that specifically shows what the change was trying to correct.
|
Closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code causes incorrect clipping. It also uses incorrect indexing (1 - d instead of just d). With this code removed, I have not been able to find a case where the scroll area contents invade the scroll bar area.
Closes #2811.