Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eframe: Add 'NativeOptions::active' #2813

Merged
merged 3 commits into from
Apr 18, 2023
Merged

eframe: Add 'NativeOptions::active' #2813

merged 3 commits into from
Apr 18, 2023

Conversation

Dixeran
Copy link
Contributor

@Dixeran Dixeran commented Mar 15, 2023

There is a option in winit's WindowBuilder called with_active which allow to avoid granting focus when window initially opened. This PR is tend to add this option into NativeOptions of eframe.

@Dixeran Dixeran marked this pull request as ready for review March 15, 2023 12:47
@Dixeran
fix: remove platform specification
27c132f 
- winit accept this option for all platforms
emilk
emilk reviewed Apr 18, 2023
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs build fix

crates/eframe/src/epi.rs Outdated Show resolved Hide resolved
@emilk emilk merged commit 8a2cfbd into emilk:master Apr 18, 2023
@emilk emilk added the eframe Relates to epi and eframe label Apr 18, 2023
@emilk emilk changed the title Apply 'with_active' option to winit eframe: Add 'NativeOptions::active' May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
eframe Relates to epi and eframe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dixeran @emilk