Prefer the client width/height for the canvas parent #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah - I'm not sure what to do about the |
|
I resync-ed with |
emilk
approved these changes
Mar 29, 2023
emilk
added
web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally,
eframetakes over the entire webpage, but sometimes, youwould like it to "play nice" and keep its canvas to a finite area. This mostly
works as long as the containing
divhas the right style properties.However, the use of
scrollheightandscrollwidthbreaks the responsive case in which the page is resized. The canvas will grow, but it will not shrink.This PR resolves #2805