Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📜 Replace ComboBox::show_index String with Into<TextWidget> #2790

Merged
merged 1 commit into from
Mar 29, 2023
Merged

📜 Replace ComboBox::show_index String with Into<TextWidget> #2790

merged 1 commit into from
Mar 29, 2023

Conversation

tosti007
Copy link
Contributor

@tosti007 tosti007 commented Mar 7, 2023

The ComboBox::show_index function currently takes a impl Fn(usize) -> String and passes that String to functions taking a impl Into<WidgetText>. We can make the show_index function more generic by using Into<WidgetText> as well.

@tosti007 tosti007 changed the title Replace ComboBox::show_index String with Into<TextWidget> 📜 Replace ComboBox::show_index String with Into<TextWidget> Mar 7, 2023
emilk
emilk approved these changes Mar 29, 2023
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@emilk emilk merged commit 5ccc714 into emilk:master Mar 29, 2023
@tosti007 tosti007 deleted the combo_box_show_index_widgettext branch March 29, 2023 15:16
@emilk emilk added feature New feature or request egui labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
egui feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tosti007 @emilk