Update serial window example #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added the updated screen shot based on the feedback and took the PR out of draft. Let me know if there is anything else I need to do. |
emilk
approved these changes
Mar 29, 2023
emilk
added
the
docs and examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm new to egui and my main experience so far has been to go through the examples and I found that for the
serial_windowsexample I wasn't sure what to expect. I've updated it to what I think would have helped me set better expectations like the other examples. I wasn't quite sure what to do with the screenshot so I left it still to get feedback on the rest first.I tried my best not to make the code more complicated but felt it was necessary to add a bit more to the UI to help the viewer understand what is happening. I was on the fence about including that the delay is 2 seconds. I think it would help but it would either need to be passed in to keep it in sync which makes the example more complicated or it would be in two places and then might go out of sync.