feat(combobox): implement text wrap for selected text #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is an example of why this feature would be important
The text can't be displayed in the screen entriely. |
- specifying a wrap width didn't really make sense so now it's boolean - the selected text will now use the maximum available width while still respecting the spacing and icon coming after it
|
I reiterated on the feature and now Also note that this doesn't break or change old code, since it deafults to the old behavior. |
|
This needs to merge in the main branch before we can merge the PR |
emilk
pushed a commit
that referenced
this pull request
Dec 2, 2022
* feat(combobox): implement text wrap for selected text * chore(changelog): add line to changelog * feat(combobox-text-wrap): make wrap boolean - specifying a wrap width didn't really make sense so now it's boolean - the selected text will now use the maximum available width while still respecting the spacing and icon coming after it * feat(combobox-text-wrap): update changelog
JohannesProgrammiert
pushed a commit
to JohannesProgrammiert/egui
that referenced
this pull request
Jan 21, 2023
* feat(combobox): implement text wrap for selected text * chore(changelog): add line to changelog * feat(combobox-text-wrap): make wrap boolean - specifying a wrap width didn't really make sense so now it's boolean - the selected text will now use the maximum available width while still respecting the spacing and icon coming after it * feat(combobox-text-wrap): update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdunder "Unreleased".If it is a non-trivial addition, consider adding a demo for it toegui_demo_lib.cargo fmtandcargo clippy../sh/check.sh.Closes #2271.