eframe: Add center to NativeOptions and monitor_size to WindowInfo
#2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ar37-rs
commented
Sep 10, 2022
ar37-rs
commented
- Make window always on top and center positioning to be configured both at runtime and initialization.
- Centering the window position at initialization it will fix the window being shown at different positions twice as if centering the window at runtime (which is doesn't seem right).
emilk
requested changes
Sep 10, 2022
Co-authored-by: Emil Ernerfeldt <[email protected]>
emilk
reviewed
Sep 17, 2022
emilk
changed the title
center to NativeOptions and monitor_size to WindowInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.