Allow box zoom in any direction for plots #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
reviewed
Sep 8, 2022
| }; | ||
| if new_bounds.is_valid() { | ||
| transform.set_bounds(new_bounds); | ||
| auto_bounds = false.into(); | ||
| } else { | ||
| auto_bounds = true.into(); |
There was a problem hiding this comment.
I have no idea why it was there in the first place, or if it's still possible to trigger.
There was a problem hiding this comment.
If you don't know why it was there, maybe it is not a good idea to remove it? :)
There was a problem hiding this comment.
I don't want box zoom to ever trigger auto bounds, we already have double clicking to reset the view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only the top-left to bottom-right direction worked.