Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom shader_version on glow renderer #1993

Merged
merged 20 commits into from
Sep 6, 2022
Merged

Add custom shader_version on glow renderer #1993

merged 20 commits into from
Sep 6, 2022

Conversation

ar37-rs
Copy link
Contributor

@ar37-rs ar37-rs commented Sep 1, 2022 •
edited
Loading

  • Fix black screen by changing shader_version to OpenGL ES 2.0 shader (ES100) on VirtualBox VMSVGA driver with OpenGL ES 2.0 and OpenGL 2.1 with no srgb support.
  • More easier cross compiling for different targets.

emilk
emilk requested changes Sep 5, 2022
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think custom_shader_version is better named as just shader_version.

crates/eframe/CHANGELOG.md Outdated Show resolved Hide resolved
crates/egui_glow/CHANGELOG.md Outdated Show resolved Hide resolved
crates/egui_glow/src/winit.rs Outdated Show resolved Hide resolved
crates/egui_glow/src/painter.rs Outdated Show resolved Hide resolved
crates/eframe/src/epi.rs Outdated Show resolved Hide resolved
crates/eframe/src/epi.rs Outdated Show resolved Hide resolved
@ar37-rs ar37-rs changed the title Add custom_shader_version on glow renderer Add custom shader_version on glow renderer Sep 6, 2022
@ar37-rs
Copy link
Contributor Author

ar37-rs commented Sep 6, 2022

Looks good, but I think custom_shader_version is better named as just shader_version.

@emilk thank you, done changed,

@ar37-rs ar37-rs requested a review from emilk September 6, 2022 05:44
@emilk emilk merged commit b43a862 into emilk:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk Awaiting requested review from emilk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ar37-rs @emilk