Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue execution after closing native eframe window #1889

Merged
merged 8 commits into from
Aug 5, 2022
Merged

Continue execution after closing native eframe window #1889

merged 8 commits into from
Aug 5, 2022

Commits on Aug 3, 2022

  1. Break up run_glow into three functions 

    This will allow us to try out another event loop,
one that continues execution after the window closes.
    @emilk
    emilk committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    657ddc5 View commit details
    Browse the repository at this point in the history

  2. Add NativeOptions::exit_on_window_close option 

    `true` by default. Only implemented for glow so far.
    @emilk
    emilk committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    c839cde View commit details
    Browse the repository at this point in the history

  3. Refactor wgpu path to also support exit_on_window_close == false

    @emilk
    emilk committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    2512aae View commit details
    Browse the repository at this point in the history

  4. Reduce code duplication

    @emilk
    emilk committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    5549910 View commit details
    Browse the repository at this point in the history

  5. Make run_return behave MUCH better

    @emilk
    emilk committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    c0fa0f8 View commit details
    Browse the repository at this point in the history

  6. Fix repaint_after

    @emilk
    emilk committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    b5ba103 View commit details
    Browse the repository at this point in the history

  7. Turn the new feature on by default

    @emilk
    emilk committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    dbbfb30 View commit details
    Browse the repository at this point in the history

  8. Better docs

    @emilk
    emilk committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    5848bd5 View commit details
    Browse the repository at this point in the history