Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to winit 0.27.1 and glutin 0.29.0 #1877

Closed
wants to merge 7 commits into from

Conversation

budde25
Copy link

@budde25 budde25 commented Aug 1, 2022

Bumps winit version

@emilk
Copy link
Owner

emilk commented Aug 1, 2022

@emilk emilk changed the title bump winit to version 27.1, and the fix deprecated methods Update to winit 0.27.1 and glutin 0.29.0 Aug 1, 2022
@dbuch
Copy link
Contributor

dbuch commented Aug 1, 2022

This closes #992 btw.

@emilk
Copy link
Owner

emilk commented Aug 4, 2022

A new wgpu release isn’t due until late September, so either we wait until then or we make egui-winit compatible with both old and new winit, with a feature-flag to select which one to use

Cargo.lock Show resolved Hide resolved
@rib
Copy link
Contributor

rib commented Aug 10, 2022

I might have a solution to this: rust-windowing/winit#2418

So this way Winit would implement the old and new raw_window_handle traits which can hopefully make Winit 0.27 compatible with wgpu 0.13

It would be good to test this egui branch against this

@emilk
Copy link
Owner

emilk commented Aug 10, 2022

I might have a solution to this: rust-windowing/winit#2418

So this way Winit would implement the old and new raw_window_handle traits which can hopefully make Winit 0.27 compatible with wgpu 0.13

It would be good to test this egui branch against this

I tested it, and it works! I added this to the root Cargo.toml:

[patch.crates-io]
winit = { git = 'https://github.com/rib/winit/', branch = 'raw_window_handle_04' }

and could then run egui_demo_app with the wgpu feature. Nice job @rib !

So this PR is now blocked on rust-windowing/winit#2418 plus a winit release.

@rib
Copy link
Contributor

rib commented Aug 11, 2022

ah, cool, thanks for testing/confirming

@kchibisov
Copy link

Winit 0.27.2 got released.

@emilk
Copy link
Owner

emilk commented Aug 14, 2022

For some reason I can no longer push to this, so I continued the work in #1914

@emilk emilk closed this Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants