Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide anchored windows the first frame #1856

Merged
merged 4 commits into from
Jul 29, 2022
Merged

Hide anchored windows the first frame #1856

merged 4 commits into from
Jul 29, 2022

Conversation

zapp88
Copy link
Contributor

@zapp88 zapp88 commented Jul 26, 2022

This PR resolves issue: #1852
We introduce dry_run flag which makes component invisible until we do second pass of rendering - which allows us to properly calculate position for anchor. (This removes rapid flicker when new window is drawn for the first time).

This PR resolves issue: #1852
We introduce dry_run flag which makes component invisible until we do second pass of rendering - which allows us to properly calculate position for anchor. (This removes rapid flicker when new window is drawn for the first time).
@zapp88 zapp88 marked this pull request as ready for review July 26, 2022 15:40
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting idea! Needs some docs / better naming though

egui/src/containers/area.rs Outdated Show resolved Hide resolved
@zapp88 zapp88 requested a review from emilk July 29, 2022 10:09
@emilk emilk merged commit 36a49ff into emilk:master Jul 29, 2022
@emilk emilk changed the title Add dry run feature for anchor calculation. (#1) Hide anchored windows the first frame Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants