Remove dependency on AsRef trait for TextBuffer #1824
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the dependency on the
AsRef<str>
trait forTextBuffer
.Rationale
That dependency is not needed as it is trivial to implement
fn as_str(&self) -> &str
for bothstr
andString
which are the default implementations provided byegui
and very likely the one that most user will ever need. ThenTextEdit
can just useas_str()
in places where it was usingas_ref()
before, which in my opinion makes it more consistent with the trait definition.In one of the project I am working on we did implement a custom
TextBuffer
for ourstruct Var
. The forced dependency onAsRef<str>
caused some pains because:struct Var
is a kind of container that can have all kind of underlying data type (not only string).We anticipate that other occurrences will appear over time and we would like to avoid them.
Checklist
./sh/check.sh
.