Fix persistence of window position #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingun
reviewed
Jun 16, 2022
egui-winit/src/window_settings.rs
Outdated
| Self { | ||
| inner_pos: window | ||
| let position = if cfg!(macos) { | ||
| // Use the inner position for MacOS |
There was a problem hiding this comment.
I think, it is better to wording like "MacOS uses inner position when positioning windows" or something, added details from your findings also would be helpful.
Right now this comment looks like Captain Obvious statement.
|
Thanks. |
Titaniumtown
pushed a commit
to Titaniumtown/egui
that referenced
this pull request
Jun 20, 2022
* Fix window position * Better comment * Add doc link
Titaniumtown
pushed a commit
to Titaniumtown/egui
that referenced
this pull request
Jun 20, 2022
* Fix window position * Better comment * Add doc link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#1737
Changes
Store the inner position only for MacOS; other platforms store the outer position.