feat: add feature for load system fonts according user input#1687
feat: add feature for load system fonts according user input#1687lj94093 wants to merge 3 commits intoemilk:mainfrom
Conversation
|
Hi, and thanks for the PR! Can you describe what this is supposed to do? The new code is very sparse on documentation. I ran it on my mac and pasted some Japanese characters into a text box. The app froze for a second, and then the familiar
|
|
Sorry for didn't test it on mac os.I tested it on my Windows. The correct way for use this feature is add The reason for it didn't load correct fonts on mac is that Luckily,I find that skia-safe already load the font data from disk.So we don't need to load fonts by I fix it in later 2 commits. Reason for didn't implement it with a plugin system: If I find a better way to to choose the font for characters and make the binary size small enough.Then we can implement such a plugin system. |
Solved the issure mentioned in #1344.
For now,this PR adds a
system_fontsfeature which depend the font-kits and skia-safe(glfeature) and it makes the binary size very big.So I add it as a optional feature inepaint,eguiandeframefor some people who need it.Maybe I should develop a library to choose the font for characters.But it sounds like there are lots of work to do.If i finished it or find a proper library,i will make a PR again add as the default feature of
eframe.So for now,Let's just make it as a experimental feature.